Skip to content

fix: sanitize shell/subprocess call in apt-packages-origin #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 2 commits into
base: 19.x
Choose a base branch
from
Open

fix: sanitize shell/subprocess call in apt-packages-origin #371

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ed894d
fix: V-001 security vulnerability
anupamme Jul 30, 2026
11cde83
fix: resolve bytes/str mismatch and Python 2 syntax in apt-packages-o…
anupamme Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions overlays/bootstrap_apt/usr/local/bin/apt-packages-origin
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/usr/bin/python
#!/usr/bin/python3
# Author: Liraz Siri <liraz@turnkeylinux.org>
# list origin of packages

Expand Down Expand Up @@ -52,7 +52,13 @@ def parse_policies(fh):
yield pp

def main():
proc = subprocess.Popen(args="apt-cache policy $(dpkg -l | grep ^ii | awk '{print $2}')", shell=True, bufsize=1, stdout=subprocess.PIPE)
dpkg_proc = subprocess.Popen(['dpkg', '-l'], stdout=subprocess.PIPE, text=True)
pkgs = [line.split()[1] for line in dpkg_proc.stdout if line.startswith('ii')]
dpkg_proc.wait()
if dpkg_proc.returncode != 0:
raise SystemExit('dpkg -l failed with returncode %d' % dpkg_proc.returncode)
# if pkgs is empty, apt-cache policy runs with no args and lists policy for all packages
proc = subprocess.Popen(['apt-cache', 'policy'] + pkgs, bufsize=1, stdout=subprocess.PIPE, text=True)

rows = []
for pp in parse_policies(proc.stdout):
Expand All @@ -72,7 +78,7 @@ def main():

fmt = "%%-%ds %%-%ds %%s" % (maxcols[0], maxcols[1])
for row in rows:
print fmt % tuple(row)
print(fmt % tuple(row))

if __name__ == "__main__":
main()