[pull] master from php:master#1046
Merged
Merged
Conversation
Saves an offset load every time they're accessed Closes GH-22287
In the NORMAL condition a lone unterminated quote matched no rule, so re2c backtracked to a zero-length GENERIC_ID accept. The rule body then computed yyleng - unescape_string(yytext) as 0 - N, underflowing size_t into a multi-gigabyte estrndup. Give a bare quote an explicit one-character accept so the cursor advances and unescape_string is never reached with a malformed token. Fixes GH-17387 Closes GH-22506
* PHP-8.4: Fix GH-17387: crash on unterminated quote in phpdbg lexer
* PHP-8.5: Fix GH-17387: crash on unterminated quote in phpdbg lexer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )