[pull] master from php:master#1043
Merged
Merged
Conversation
IntlIterator::current() could expose an undefined zval when called before theiterator is positioned, or after the iterator becomes invalid. In these cases we directly returns the undefined zval and cause to a UNKNOWN:0 output in userland. Generally, a NULL output would be more proper.
zend_compile_var_inner did not route ZEND_AST_PIPE through zend_compile_memoized_expr, so a pipe on the left-hand side of ??= was recompiled during the FETCH pass. zend_compile_pipe synthesizes a fresh call node on each pass, so the memoized-result lookup keyed by that node returned NULL and was dereferenced. Memoize the pipe like the other call kinds zend_is_call() already recognizes. Fixes GH-22490
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )