Auto-detect Desoutter controllers during the handshake - #6
Open
iitalics wants to merge 1 commit into
Open
Conversation
Desoutter controllers reject any stationID/spindleID other than blanks. The serializer could already blank them out, but only via a constructor option decided before we know what we're talking to. Make the mode settable at runtime through the whole stack (SessionControlClient -> LinkLayer -> OpenProtocolSerializer), and turn it on automatically when the MID 2 reply of the handshake reports a supplier code starting with "DE". Detection only ever enables the mode, and is skipped entirely when the caller passed an explicit value, so other controllers keep their current behavior. Note that MID 2 revision 1 carries no supplier code, so detection needs revision 2 or higher. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desoutter controllers reject any stationID/spindleID other than blanks. The serializer could already blank them out, but only via a constructor option decided before we know what we're talking to.
Make the mode settable at runtime through the whole stack (SessionControlClient -> LinkLayer -> OpenProtocolSerializer), and turn it on automatically when the MID 2 reply of the handshake reports a supplier code starting with "DE". Detection only ever enables the mode, and is skipped entirely when the caller passed an explicit value, so other controllers keep their current behavior. Note that MID 2 revision 1 carries no supplier code, so detection needs revision 2 or higher.