test: repro #34 — generated connector rail runs parallel to same-net trace rail#708
Closed
DPS0340 wants to merge 1 commit into
Closed
test: repro #34 — generated connector rail runs parallel to same-net trace rail#708DPS0340 wants to merge 1 commit into
DPS0340 wants to merge 1 commit into
Conversation
…same-net trace rail Pins the remaining tscircuit#34 symptom on example45: the rail-alignment cleanup from tscircuit#663 excludes generated net-label connector traces (eligibleTraceIds is derived from the first cleanup pass, which runs before AvailableNetOrientationSolver creates connectors), so the SDA connector rail at x=10.42 stays 0.166 from the same-net R10.2-CONN1.3 rail at x=10.58 instead of merging onto one line. A fix should flip the assertion to .toEqual([]).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction PR for the remaining #34 symptom, following the repo's repro-first workflow.
The rail-alignment cleanup from #663 handles most same-net close-rail cases, but generated net-label connector traces are excluded from the eligible set:
traceCleanupSolver2deriveseligibleTraceIdsfrom the first cleanup pass, which runs beforeAvailableNetOrientationSolvercreates the connectors.On
example45(already in the repo) the generatedSDAconnector runs a vertical rail atx=10.42while the same-netR10.2->CONN1.3trace runs a parallel rail 0.166 away atx=10.58, with 0.5 of overlapping length — two rails that should be one line:The test asserts exactly this unmerged rail pair (with a visual snapshot), so a fix flips the assertion to
.toEqual([]).Proposed fix in #700 (separate PR,
/claim #34there): add the generatedavailable-net-orientation-*traces to the alignment pass's eligible set — the existing #663 merging machinery then pulls them onto the shared coordinate. Happy to rebase #700 on this repro once it lands.