test: repro #674 — net-label connector traces cross other nets' traces#706
Closed
DPS0340 wants to merge 1 commit into
Closed
test: repro #674 — net-label connector traces cross other nets' traces#706DPS0340 wants to merge 1 commit into
DPS0340 wants to merge 1 commit into
Conversation
…ts' traces Pins the current behavior on the tscircuit#674 board (_board#665 input): AvailableNetOrientationSolver places connector traces without checking whether they cross traces from other nets, producing three crossings that each render as a false junction: JP1.1-SJ3.1 x available-net-orientation-3-V3_3 at (-7.1,-6.1) U1.1-U1.3 x available-net-orientation-5-GND at (-1.8,0.2) available-net-orientation-4-V3_3 x available-net-orientation-9-GND A fix should flip the assertion to .toEqual([]).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Jul 24, 2026
Author
|
Superseded by #703, which contains this same regression test ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction PR for #674, following the repo's repro-first workflow.
Pins the current behavior on the #674 board (
_board#665input, attached to the issue):AvailableNetOrientationSolverplaces net-label connector traces without checking whether they cross traces from other nets. Each perpendicular crossing renders as a false junction. Three appear on this board:The test asserts exactly these three crossings (with a visual snapshot), so a fix flips the assertion to
.toEqual([]).Proposed fix in #703 (separate PR): reject connector candidates that cross other nets during candidate evaluation, with an orientation-constraint-preserving fallback. That fix clears the same class of crossing on example45 and bug-report-20260708T055430Z; the three crossings here are the walled-in cases needing connector rerouting, documented there. Happy to rebase #703 on this repro once it lands.