test: repro #655 — net labels are placed inside chip bodies#705
Closed
DPS0340 wants to merge 1 commit into
Closed
Conversation
Pins the current behavior on bug-report-20260707T230831Z: the VIN, PG, VOUT and 'U1.FB to R2.pin1' net labels all end up 100% inside chip bodies, rendering behind the components. NetLabelNetLabelCollisionSolver only relocates labels that overlap another label; a label inside a chip without a label-label collision is never checked against chips. Several chips on this board also overlap each other, so port-only labels anchored on covered pins collide in every orientation at their pin anchor. A fix should flip the assertion to .toEqual([]).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction PR for #655, following the repo's repro-first workflow.
Pins the current behavior on
bug-report-20260707T230831Z(already in the repo): theVIN,PG,VOUTandU1.FB to R2.pin1net labels end up 100% inside chip bodies, rendering behind the components and illegible.Root cause (as noted in the issue):
NetLabelNetLabelCollisionSolver.findNextCollidingPaironly looks for label-label overlaps, so a label inside a chip that isn't also colliding with another label is never relocated. A second layer: several chips on this board overlap each other, so a pin can be covered by another chip's body — port-only labels anchored on such pins collide in every orientation, meaning a fix also needs an anchor-escape strategy, not just a chip-collision pass.The test asserts exactly the four buried labels, so a fix flips the assertion to
.toEqual([]).Proposed fix in #699 (separate PR): chip-collision relocation pass + outward anchor sliding for port-only labels. Verified there against all 21 bug-report boards (5 boards with buried labels on
main→ 0). Happy to rebase #699 on this repro once it lands.