test: repro #670 — labeled rail nets get long bus traces instead of net labels#704
Closed
DPS0340 wants to merge 1 commit into
Closed
test: repro #670 — labeled rail nets get long bus traces instead of net labels#704DPS0340 wants to merge 1 commit into
DPS0340 wants to merge 1 commit into
Conversation
…tead of net labels Pins the current behavior on the tscircuit#670 board: LongDistancePairSolver connects pins on the labeled V3_3/GND rails (JP1.2-JP2.2, D2.2-JP6.1, U1.2-JP6.2 — each 8-10 units apart, every pin already receiving a net label) with 9-13 unit orthogonal bus traces. A fix should flip the assertion to .toEqual([]).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction PR for #670, following the repo's repro-first workflow (per the review guidance on #690).
Pins the current behavior on the #670 board (
_board#1332input):LongDistancePairSolverconnects pins on the labeled V3_3/GND rails with long orthogonal bus traces even though every one of those pins already receives a net label (V3_3 declaredy+, GNDy-):The test asserts exactly these three traces exist (with a visual snapshot), so a fix flips the assertion to
.toEqual([]).Proposed fix in #702 (separate PR): cap long-distance neighbor candidates at
maxMspPairDistancefor labeled nets with >2 pins — the same thresholdMspConnectionPairSolveralready uses when it decides a pair should stay label-connected.