fix: prevent hash overflow to NaN in getColorFromString (#651)#689
Open
thairc-dev wants to merge 2 commits into
Open
fix: prevent hash overflow to NaN in getColorFromString (#651)#689thairc-dev wants to merge 2 commits into
thairc-dev wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
Unit test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #651
Cause
When passing long strings (e.g.
"n".repeat(300)), accumulatingacc * 31 + charCodeAt(0)overflows JavaScript'sNumber.MAX_VALUEtoInfinity. Subsequently,Infinity % 360evaluates toNaN, returning an invalid color stringhsl(NaN, 100%, 50%, 1).Solution
| 0) on each hash accumulation step to keep the hash bounded within signed 32-bit integer range.Math.abs(hash) % 360to guarantee a valid non-negative hue integer between 0 and 359.Verification
Added
tests/getColorFromString.test.tsverifying valid HSL format, alpha parameter handling, and long string handling ("n".repeat(300)). All tests pass cleanly.