fix: honour schShowRatings={false} on fuse (#2835)#2836
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
64c7927 to
0f297e6
Compare
|
Housekeeping — rebased onto current Since I have several PRs open here now, a note on how they interact so none of this lands on you: Five of the seven are fully independent — they touch different files and merge in any order:
Two pairs conflict, and both are trivial:
Happy to do the merge myself: say the word and I'll combine any subset into a single PR, or rebase the losers as soon as the first one lands. I'd rather you not spend time on conflict resolution for my changes. I verified the above rather than assuming it — checked all 21 branch pairs for conflicts and confirmed each rebases cleanly onto |
0f297e6 to
4a967f7
Compare
Closes #2835.
schShowRatingsis declared onFuseProps("Whether to show ratings on schematic") butFusenever read it, soschShowRatings={false}rendered the ratings anyway.Deliberately narrow, and here's why
The obvious "fix" would be to mirror
Capacitor, which shows ratings only on opt-in. I checked the schemas before assuming they're equivalent, and they aren't:Capacitor's default is part of its schema; fuse has no default to read off, and it has always shown ratings unconditionally. Switching fuse to opt-in would silently blank the ratings on every existing fuse schematic — a behaviour change dressed up as a bug fix. So this PR only makes the explicit
falsework:undefined(prop omitted) andtrueboth keep today's output byte-for-byte. If you'd rather fuse match capacitor's opt-in default, I'm happy to send that as a follow-up — it's a product decision, not a defect, and it deserves its own review.Verification
The test bites. Reverting only
Fuse.ts:It asserts all three states in one board, so a regression in either direction — breaking the default or failing to suppress — is caught.
Suite:
1260 pass / 0 fail, and no snapshots changed, which is the evidence that the default path is untouched.biome formatandtsc --noEmitclean.Relationship to #2834
Independent — that one fixes the
"1A / V"bare-unit output whenvoltageRatingis omitted; this one fixes the ignored prop. They touch the same method, so whichever lands first will need a trivial rebase of the other. Happy to combine them into one PR if you'd prefer a single review.