Support children in schematic sections#2791
Draft
MustafaMulla29 wants to merge 2 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
schSectionNameoverride<schematicsection>and<schematicsheet>as transparent when finding direct schematic layout childrenWhy
Although React could attach children beneath
<schematicsection>, section membership was only read from each component's ownschSectionNameprop. The section wrapper also hid those source components from layout code that scanned only direct group children. As a result, nesting components inside a section did not assign or lay them out as members of that section.Impact
Users can group components naturally by nesting them inside
<schematicsection>, matching the container-style API already provided by<schematicsheet>. Existing explicitschSectionNameusage continues to take precedence.Dependency
Depends on tscircuit/props#749 for the public
childrenprop type and schema.Validation
bunx tsc --noEmitbun run build