Simplify things#6
Merged
Merged
Conversation
entpiske
commented
Jul 21, 2026
| ) | ||
|
|
||
| ::ActiveRecord::MigrationContext.new(path, schema_migration).migrate | ||
| ActiveRecord::MigrationContext.new(path).migrate |
Member
Author
There was a problem hiding this comment.
Bringing adamniedzielski#102 (comment) over here.
Co-authored-by: Arek W <arek01@gmail.com>
entpiske
commented
Jul 21, 2026
|
|
||
| def authentication_keys | ||
| mapping.to.authentication_keys | ||
| if mapping.to.authentication_keys.is_a?(Hash) |
Member
Author
There was a problem hiding this comment.
This and the corresponding spec: I copy & pasted from adamniedzielski#102 (added co-authorship to the original author).
entpiske
marked this pull request as ready for review
July 21, 2026 21:41
mhfs
approved these changes
Jul 21, 2026
entpiske
added a commit
that referenced
this pull request
Jul 22, 2026
* fix(security): relax devise constraint to allow devise 5.x Relaxes the devise dependency from `< 5` to `< 6` to allow consumers to upgrade to devise 5.0.3 which fixes CVE-2026-32700 (confirmable race condition). Tiddle uses only stable Devise APIs (Devise.add_module, Devise::Strategies::Authenticatable, Devise.token_generator) that are unchanged in devise 5.x. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore(ci): drop Rails 6.1 from test matrix Rails 6.1 is EOL and incompatible with Ruby 3.x (LoggerThreadSafeLevel errors). All consumers use Rails 7.2+. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Bump dependencies (#5) * bump dependencies * remove not needed deps * Add a changelog entry * update GHA * fix mongoid --------- Co-authored-by: André Diego Piske <andrepiske@gmail.com> * Simplify things (#6) * Simplify things * Adds support for `config.authentication_keys` in hash format Co-authored-by: Arek W <arek01@gmail.com> * remove appraisals * database_cleaner not needed here explicitly --------- Co-authored-by: André Diego Piske <andrepiske@gmail.com> Co-authored-by: Arek W <arek01@gmail.com> * Nitpicking: Remove comments (#7) * remove comment * there is no gemfile --------- Co-authored-by: André Diego Piske <andrepiske@gmail.com> --------- Co-authored-by: Mateus Bittencourt <mateus.bittencourt@trustedhealth.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Mateus Bittencourt <mateus.lbittencourt@gmail.com> Co-authored-by: André Diego Piske <andrepiske@gmail.com> Co-authored-by: Arek W <arek01@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR essentially addresses a few comments from Adam (this gem's original author) in adamniedzielski#103 -- which simplifies things a bit.