[ARM] Allow -fzero-call-used-regs on 32-bit Arm - #22
Open
kumarak wants to merge 1 commit into
Open
Conversation
The driver rejected the flag on Arm through a hard-coded list of targets, carrying a FIXME that the restriction had no good reason beyond the backend work not being done. The backend now clears the call-used registers on Arm, Thumb-1 and Thumb-2, so the reason is gone and the two request paths agree: the flag and the function attribute reach the same place. A target whose backend still does not implement the clear is refused as before, which the test pins with PowerPC. This is trailofbits/vspells-ct-internal-notes#52, under the umbrella trailofbits/vspells-ct-internal-notes#30.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The driver rejected the flag on Arm through a hard-coded list of targets, carrying a FIXME that the restriction had no good reason beyond the backend work not being done. The backend now clears the call-used registers on Arm, Thumb-1 and Thumb-2, so the reason is gone and the two request paths agree: the flag and the function attribute reach the same place.
A target whose backend still does not implement the clear is refused as before, which the test pins with PowerPC.
This is trailofbits/vspells-ct-internal-notes#52, under the umbrella trailofbits/vspells-ct-internal-notes#30.