Skip to content

Align shafts: clock rotation and rename - #247

Merged
trailcode merged 5 commits into
mainfrom
Trailcode/allign_shafts
Aug 5, 2026
Merged

Align shafts: clock rotation and rename#247
trailcode merged 5 commits into
mainfrom
Trailcode/allign_shafts

Conversation

@trailcode

@trailcode trailcode commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • Rename Align cylinders to Align shafts (toolbar, hotkeys label, docs); keep remappable id mode.cyl_align.
  • Add Options Clock rotation (default off): after insert-depth drag, roll about the shared axis for tooth clocking (LMB / Shift+Tab; Tab for depth or angle; Enter can skip).
  • Extend cyl_align_trsf with optional twist about the fixed axis.

Closes #246

Test plan

  • Build Release EzyCad.
  • Align shafts with Clock rotation off: pick faces, drag depth, LMB/Enter finalize.
  • Clock rotation on: depth then drag clock; Shift+Tab / Tab angle edit; Enter from depth skips clock.
  • Flip direction still works during preview.
  • Radius mismatch still warns and places.
  • Toolbar tooltip and Settings -> Keyboard shortcuts show Align shafts.
  • Docs: usage.md Align Shafts section and hotkey table.

Notes

Made with Cursor

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit aafc607. Configure here.

Comment thread src/shp_cyl_align.cpp
if (m_opts.clock_rotation)
enter_twist_();
else
finalize();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab depth Enter skips clock

Medium Severity

With Clock rotation on, confirming the Tab depth popup (is_final) calls enter_twist_() instead of baking. The mode Enter handler always finalize()s from depth and skips clocking, as documented. Pressing Enter after typing depth therefore enters clock rotation instead of finishing the align.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit aafc607. Configure here.

@trailcode
trailcode merged commit fa27cac into main Aug 5, 2026
4 checks passed
@trailcode
trailcode deleted the Trailcode/allign_shafts branch August 5, 2026 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align shafts: clock rotation for tooth clocking

1 participant