Fix theme toggle icon showing wrong state on initial load#264
Merged
Conversation
Added forced signal resync in createTheme onMount before observer attaches to lib/theme.ts in vendor/trailbase admin UI Fixed mismatch where toggle icon showed light-mode state while the resolved theme on load was already dark Provide correct initial icon state regardless of onMount race order Enable icon to reflect actual applied theme immediately on startup
Contributor
|
Much appreciated 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createTheme()seeds its signal fromcurrentTheme()beforeinitializeTheme()applies the resolved theme to<html>. The signal is meant to resync via aMutationObserver, but that observer attaches increateTheme()'s ownonMount, which fires after the parentApp'sonMountalready toggled thedarkclass — so the observer misses the mutation and the icon stays stuck on the stale initial state (moon shown on dark startup).Fix: force
setTheme(currentTheme())right before attaching the observer, resyncing to actual DOM state at mount time regardless of onMount order.Testing: verified manually with dark preference on load — icon now correct immediately; toggling still works.