fix(config): handle configuration file read errors - #4032
Open
tunglambk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OSErrorfailures intoHandledErrorRoot cause and impact
Configuration discovery only translated
ValueErrorinto tox's handled error path. Reading an existing configuration can also raise anOSErrorsubclass, such asPermissionErroror a race-timeFileNotFoundError. Those exceptions escaped totox.runand exposed a full Python traceback for a user configuration problem.Unreadable configuration files now produce the same concise
failed loadingmessage as malformed files.Fixes #4031.
Validation
pytest -q tests/config/source(201 passed)ruff check src/tox/config/source/discover.py tests/config/source/test_discover.pyruff format --check src/tox/config/source/discover.py tests/config/source/test_discover.pytox.inigit diff --checkChecklist
docs/changelog/4031.bugfix.rst