fix: reuse Windows GUID type across calls#505
Closed
Sanjays2402 wants to merge 1 commit into
Closed
Conversation
Repeated Windows folder lookups created a new ctypes Structure class, causing ctypes to retain a new pointer type per call. Cache the lazily constructed GUID type and cover its reuse with a regression test.
Member
|
Superseeded by #507, thanks for opening this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #501.
get_win_folder_via_ctypes()defined a new ctypesStructureon every lookup, so ctypes retained a new pointer type per call. This caches the lazily constructed GUID type and adds a regression test that verifies repeated lookups reuse it.Tests:
pytest -q(883 passed, 91 skipped); Ruff check and format on the changed files.