fix(build): remove fat LTO from development profile by josecelano · Pull Request #2013 · torrust/torrust-tracker

josecelano · 2026-07-21T10:35:36Z

Summary

remove the obsolete lto = "fat" override from [profile.dev], restoring Cargo's default development-profile behavior
retain fat LTO in [profile.release] for production execution performance
remove an empty Containerfile continuation line that produced Docker's NoEmptyContinuation warning
convert the issue specification to folder format and add the LTO investigation record

Validation

cargo test --tests --benches --examples --workspace --all-targets --all-features
docker build --target debug --tag torrust-tracker:debug --file Containerfile .
docker build --target release --tag torrust-tracker:release --file Containerfile .
docker build --target recipe --file Containerfile .
TORRUST_GIT_HOOKS_LOG_DIR=.tmp ./contrib/dev-tools/git/hooks/pre-commit.sh --format=json

Copilot

Pull request overview

This PR improves developer build and CI iteration speed by removing an unnecessary lto = "fat" override from the development Cargo profile, while keeping fat LTO for production release builds. It also cleans up a minor Dockerfile warning and migrates the #1875 issue spec into the repository’s folder-based issue format with an attached research record.

Changes:

Remove [profile.dev].lto = "fat" to restore Cargo’s default dev-profile LTO behavior.
Keep [profile.release].lto = "fat" unchanged for optimized production artifacts.
Fix a Containerfile empty continuation line warning and convert the #1875 spec into folder format with a research note.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`Cargo.toml`	Removes dev-profile fat LTO while retaining release-profile fat LTO.
`Containerfile`	Removes an empty continuation line that triggered Docker’s `NoEmptyContinuation` warning.
`docs/issues/open/1875-review-lto-fat-in-dev-profile/ISSUE.md`	New folder-format issue spec documenting scope, verification, and acceptance criteria.
`docs/issues/open/1875-review-lto-fat-in-dev-profile/research.md`	Adds investigation notes and rationale for restoring dev-profile defaults.
`docs/issues/open/1875-review-lto-fat-in-dev-profile.md`	Removes the old standalone issue-spec file in favor of the new folder format.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

codecov · 2026-07-21T11:04:31Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.51%. Comparing base (f797ea7) to head (f375d34).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2013      +/-   ##
===========================================
+ Coverage    81.20%   81.51%   +0.30%     
===========================================
  Files          340      340              
  Lines        24000    24000              
  Branches     24000    24000              
===========================================
+ Hits         19490    19564      +74     
+ Misses        4200     4147      -53     
+ Partials       310      289      -21

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

docs/pr-reviews/pr-2013-copilot-suggestions.md:32

The Workflow section still omits the required “reply before resolve” step, even though the template and the process-copilot-suggestions skill now require replying on every PR suggestion thread (including no-action) before resolving. This doc should match the template/skill so it doesn’t guide future audits to resolve threads without a visible PR reply.

3. Process suggestions one by one:
   - decide `action` or `no-action`
   - if `action`, apply change and validate
   - if needed, commit changes
   - reply on the PR thread with the fix commit and outcome, or the no-action rationale
   - resolve the PR thread

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

- reply-to-thread.sh: guard against empty/null REPLY_URL from GraphQL; exit 1 if the mutation returns no comment URL so callers detect failure. - reply-and-resolve-thread.sh: same guard before proceeding to resolve, preventing a silent resolve when the reply was never posted. - check-thread-reply-status.sh: replace printf JSON construction with jq -n / --argjson so url:null is emitted as JSON null instead of the string "null". Addresses Copilot review threads PRRT_kwDOGp2yqc6Sj3Ce, PRRT_kwDOGp2yqc6Sj3Cy, PRRT_kwDOGp2yqc6Sj3DE on PR torrust#2013.

josecelano · 2026-07-21T11:56:02Z

ACK 309426b

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

   ```bash
   git add <files>
-   git commit -S -m "chore(review): <concise description>"
+   git commit -S -m "fix(review): <concise description>"


- reply-to-thread.sh: guard against empty/null REPLY_URL from GraphQL; exit 1 if the mutation returns no comment URL so callers detect failure. - reply-and-resolve-thread.sh: same guard before proceeding to resolve, preventing a silent resolve when the reply was never posted. - check-thread-reply-status.sh: replace printf JSON construction with jq -n / --argjson so url:null is emitted as JSON null instead of the string "null". Addresses Copilot review threads PRRT_kwDOGp2yqc6Sj3Ce, PRRT_kwDOGp2yqc6Sj3Cy, PRRT_kwDOGp2yqc6Sj3DE on PR torrust#2013.

Added rows for PRRT_kwDOGp2yqc6Sj3Ce, PRRT_kwDOGp2yqc6Sj3Cy, PRRT_kwDOGp2yqc6Sj3DE — all resolved in commit 3039b38.

josecelano · 2026-07-21T13:25:36Z

ACK f375d34

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

+Issue and EPIC specs use a folder named after the GitHub issue. The primary specification file
+inside the folder is `ISSUE.md` for issues or `EPIC.md` for EPICs.


+Output:
+  - JSON lines to stdout, one per unresolved thread:
+      {"thread_id":"...","path":"...","url":"...","has_reply":true|false}
+  - Summary line at the end:
+      {"summary":true,"total":N,"with_reply":N,"without_reply":N}


Copilot AI review requested due to automatic review settings July 21, 2026 10:35

josecelano temporarily deployed to coverage July 21, 2026 10:35 — with GitHub Actions Inactive

Copilot started reviewing on behalf of josecelano July 21, 2026 10:36 View session

josecelano self-assigned this Jul 21, 2026

Copilot AI reviewed Jul 21, 2026

View reviewed changes

Comment thread docs/issues/open/1875-review-lto-fat-in-dev-profile/ISSUE.md

Copilot AI review requested due to automatic review settings July 21, 2026 10:42

josecelano temporarily deployed to coverage July 21, 2026 10:42 — with GitHub Actions Inactive

josecelano temporarily deployed to coverage July 21, 2026 10:43 — with GitHub Actions Inactive

Copilot started reviewing on behalf of josecelano July 21, 2026 10:43 View session

Copilot AI reviewed Jul 21, 2026

View reviewed changes

Comment thread docs/pr-reviews/pr-2013-copilot-suggestions.md

Copilot AI review requested due to automatic review settings July 21, 2026 10:55

josecelano requested a review from a team as a code owner July 21, 2026 10:55

josecelano temporarily deployed to coverage July 21, 2026 10:55 — with GitHub Actions Inactive

Copilot started reviewing on behalf of josecelano July 21, 2026 10:56 View session

Copilot AI reviewed Jul 21, 2026

View reviewed changes

Comment thread docs/pr-reviews/pr-2013-copilot-suggestions.md

Copilot AI review requested due to automatic review settings July 21, 2026 11:07

josecelano temporarily deployed to coverage July 21, 2026 11:07 — with GitHub Actions Inactive

Copilot started reviewing on behalf of josecelano July 21, 2026 11:14 View session

josecelano temporarily deployed to coverage July 21, 2026 11:14 — with GitHub Actions Inactive

Copilot AI reviewed Jul 21, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 21, 2026 11:16

Copilot started reviewing on behalf of josecelano July 21, 2026 11:16 View session

Copilot AI reviewed Jul 21, 2026

View reviewed changes

Comment thread docs/pr-reviews/pr-2013-copilot-suggestions.md

Copilot AI review requested due to automatic review settings July 21, 2026 11:28

josecelano temporarily deployed to coverage July 21, 2026 11:28 — with GitHub Actions Inactive

Copilot started reviewing on behalf of josecelano July 21, 2026 11:29 View session

Copilot AI reviewed Jul 21, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 21, 2026 11:41

josecelano temporarily deployed to coverage July 21, 2026 11:41 — with GitHub Actions Inactive

Copilot started reviewing on behalf of josecelano July 21, 2026 11:43 View session

josecelano temporarily deployed to coverage July 21, 2026 11:46 — with GitHub Actions Inactive

Copilot AI reviewed Jul 21, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 21, 2026 11:47

josecelano temporarily deployed to coverage July 21, 2026 11:53 — with GitHub Actions Inactive

josecelano temporarily deployed to coverage July 21, 2026 11:55 — with GitHub Actions Inactive

Copilot started reviewing on behalf of josecelano July 21, 2026 11:56 View session

Copilot AI reviewed Jul 21, 2026

View reviewed changes

Comment thread .github/skills/dev/pr-reviews/process-copilot-suggestions/SKILL.md

```bash

git add <files>

git commit -S -m "chore(review): <concise description>"

git commit -S -m "fix(review): <concise description>"

josecelano added 11 commits July 21, 2026 14:24

fix(build): remove fat LTO from development profile

8deecfd

docs(issues): fix issue 1875 spec references

71abb9d

docs(review): record PR 2013 Copilot audit

6a8e8cf

docs(review): require replies to Copilot suggestions

1453693

docs(review): add cspell:disable to PR suggestion trackers

4dd3dc8

docs(review): add reply step to PR 2013 suggestion tracker workflow

266ab85

docs(review): add blank line before step 4 in tracker workflow

80924ca

docs(review): enforce reply-then-resolve per thread in copilot workflow

993ec09

docs(agents): add Copilot Suggestions Handler agent

d999ce8

docs(pr-2013): update Copilot suggestions tracker with threads 5-7

f375d34

Added rows for PRRT_kwDOGp2yqc6Sj3Ce, PRRT_kwDOGp2yqc6Sj3Cy, PRRT_kwDOGp2yqc6Sj3DE — all resolved in commit 3039b38.

Copilot AI review requested due to automatic review settings July 21, 2026 13:24

josecelano force-pushed the 1875-review-lto-fat-in-dev-profile branch from 309426b to f375d34 Compare July 21, 2026 13:24

josecelano temporarily deployed to coverage July 21, 2026 13:24 — with GitHub Actions Inactive

Copilot started reviewing on behalf of josecelano July 21, 2026 13:29 View session

Copilot AI reviewed Jul 21, 2026

View reviewed changes

josecelano merged commit a4105db into torrust:develop Jul 21, 2026
20 checks passed

		Issue and EPIC specs use a folder named after the GitHub issue. The primary specification file
		inside the folder is `ISSUE.md` for issues or `EPIC.md` for EPICs.

Uh oh!

Conversation

josecelano commented Jul 21, 2026

Summary

Validation

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

codecov Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

josecelano commented Jul 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

josecelano commented Jul 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Jul 21, 2026 •

edited

Loading