Skip to content

fix: response model correctly wrapped for new instructor versions#3080

Draft
siillee wants to merge 3 commits into
mainfrom
fix-instructor-response-model-handling
Draft

fix: response model correctly wrapped for new instructor versions#3080
siillee wants to merge 3 commits into
mainfrom
fix-instructor-response-model-handling

Conversation

@siillee

@siillee siillee commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Description

This PR fixes an issue we have with instructor 1.15.3 and possibly newer versions, regarding how the str respone model is handled. The fix is a simple Pydantic model wrapper around the response model.
In previous versions, instructor handled when the response model is not a Pydantic model. As of 1.15.3, they don't do that, and certain function calls fail, expecting a Pydantic model.

Acceptance Criteria

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Code refactoring
  • Other (please specify):

Screenshots

Pre-submission Checklist

  • I have tested my changes thoroughly before submitting this PR (See CONTRIBUTING.md)
  • This PR contains minimal changes necessary to address the issue/feature
  • My code follows the project's coding standards and style guidelines
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if applicable)
  • All new and existing tests pass
  • I have searched existing PRs to ensure this change hasn't been submitted already
  • I have linked any relevant issues in the description
  • My commits have clear and descriptive messages

DCO Affirmation

I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.

@siillee siillee requested review from NMZivkovic, dexters1 and nfnt June 16, 2026 14:33
@siillee siillee self-assigned this Jun 16, 2026
@siillee siillee requested a review from Vasilije1990 as a code owner June 16, 2026 14:33
@siillee siillee marked this pull request as draft June 16, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant