[codex] Persist graph trace for context-only retrieval#3073
Open
shuzhouzhang wants to merge 1 commit into
Open
[codex] Persist graph trace for context-only retrieval#3073shuzhouzhang wants to merge 1 commit into
shuzhouzhang wants to merge 1 commit into
Conversation
Contributor
|
Hello @shuzhouzhang, thank you for submitting a PR! We will respond as soon as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
persist_traceflag for context-only search and recall callsWhy
When
only_context=True, Cognee skips completion generation. That also meant graph trace metadata was not saved, so later feedback/improve flows could not know which graph elements were used for the returned context.Validation
.\.venv\Scripts\python -m pytest cognee\tests\unit\modules\retrieval\graph_completion_retriever_test.py cognee\tests\unit\modules\search\test_get_retriever_output.py -q.\.venv\Scripts\python -m py_compile cognee\modules\retrieval\graph_completion_retriever.py cognee\modules\search\methods\get_retriever_output.py cognee\modules\search\methods\search.py cognee\api\v1\search\search.py cognee\api\v1\search\routers\get_search_router.py cognee\api\v1\recall\recall.py cognee\api\v1\recall\routers\get_recall_router.py cognee\api\v1\serve\cloud_client.py cognee\tests\unit\modules\retrieval\graph_completion_retriever_test.py cognee\tests\unit\modules\search\test_get_retriever_output.pygit diff --checkFixes #2910