ci(frontend): add timeout and concurrency to lockfile workflow (follow-up to #2834)#3038
Open
Vasilije1990 wants to merge 1 commit into
Open
ci(frontend): add timeout and concurrency to lockfile workflow (follow-up to #2834)#3038Vasilije1990 wants to merge 1 commit into
Vasilije1990 wants to merge 1 commit into
Conversation
Address CodeRabbit review feedback on #2834: cap the lockfile verification job at 10 minutes so hung npm installs cannot consume runners for hours, and cancel superseded in-progress runs on the same ref to avoid redundant CI usage. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2834, stacked on its head branch
fix/frontend-package-lock.Addresses the two unresolved CodeRabbit review suggestions on the new
frontend_lockfile.ymlworkflow:timeout-minutes: 10to thefrontend-lockfilejob so a hungnpm cicannot occupy a runner for the default 6 hours — lockfile verification should finish in well under a minute.concurrencyblock (${{ github.workflow }}-${{ github.ref }},cancel-in-progress: true) so rapid successive pushes cancel superseded runs instead of queueing redundant ones.No behavior change for the verification itself; this only tightens resource usage.
Tests
python3 -c "import yaml; yaml.safe_load(open('.github/workflows/frontend_lockfile.yml'))"parses cleanly.🤖 Generated with Claude Code