Conversation
What was broken The Marathon Match scorer config editor already loaded and saved scoreDirection, but operators had no field in the Work app to choose MAXIMIZE or MINIMIZE. Root cause (if identifiable) The UI draft and API payload included scoreDirection defaults, but the Scorer Settings form did not render a control for it. What was changed Added a Score Direction radio group with Maximize and Minimize options, defaulting to Maximize when the draft has no saved direction. Wired the radio choice into the existing scorer config draft and save payload. Added local styles matching the existing settings grid. Any added/updated tests Added a MarathonMatchScorerSection test covering the default Maximize selection and saving Minimize to the create config payload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The Marathon Match scorer config editor already loaded and saved scoreDirection, but operators had no field in the Work app to choose MAXIMIZE or MINIMIZE.
Root cause (if identifiable)
The UI draft and API payload included scoreDirection defaults, but the Scorer Settings form did not render a control for it.
What was changed
Added a Score Direction radio group with Maximize and Minimize options, defaulting to Maximize when the draft has no saved direction. Wired the radio choice into the existing scorer config draft and save payload. Added local styles matching the existing settings grid.
Any added/updated tests
Added a MarathonMatchScorerSection test covering the default Maximize selection and saving Minimize to the create config payload.
Validation note: the targeted MarathonMatchScorerSection spec passes. yarn lint and yarn run build pass. The full yarn test:no-watch --runInBand command was run and fails in unrelated existing suites outside this change, including wallet-admin module-resolution specs, ReviewersField mocked-service specs, and existing engagements/payment validation specs.