Conversation
What was broken - Active challenge saves could show a success-only state after an attempted active phase shortening, even when challenge-api kept the original timeline. Root cause - The editor reset and navigated with the patch response, which could echo submitted phase dates instead of the persisted schedule state. What was changed - Active scheduled challenge saves now refetch the persisted challenge before resetting or navigating. - Rejected active-phase shortening is detected from the fresh schedule and shown as a partial-save warning while other saved fields remain saved. - Challenge editor docs were updated for the post-save schedule verification behavior. Any added/updated tests - Added a ChallengeEditorForm regression test for a patch response that echoes shortened phase dates while the persisted timeline remains unchanged. - Validation run: focused PM-5446 test passed; lint passed; build passed with existing warnings. Full yarn test:no-watch --runInBand still fails on unrelated existing wallet-admin alias/icon issues and pre-existing launch approval expectations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Root cause
What was changed
Any added/updated tests