Skip to content

PM-5446: Restore persisted active schedules#1986

Merged
jmgasper merged 1 commit into
devfrom
PM-5446
Jun 24, 2026
Merged

PM-5446: Restore persisted active schedules#1986
jmgasper merged 1 commit into
devfrom
PM-5446

Conversation

@jmgasper

Copy link
Copy Markdown
Collaborator

What was broken

  • Active challenge saves could show a success-only state after an attempted active phase shortening, even when challenge-api kept the original timeline.
  • The view page could temporarily show the shortened timeline until a refresh restored the persisted schedule.

Root cause

  • The editor reset and navigated with the patch response, which could echo submitted phase dates instead of the persisted schedule state.

What was changed

  • Active scheduled challenge saves now refetch the persisted challenge before resetting or navigating.
  • Rejected active-phase shortening is detected from the fresh schedule and shown as a partial-save warning while other saved fields remain saved.
  • Challenge editor docs were updated for the post-save schedule verification behavior.

Any added/updated tests

  • Added a ChallengeEditorForm regression test for a patch response that echoes shortened phase dates while the persisted timeline remains unchanged.
  • Validation run: focused PM-5446 test passed; lint passed; build passed with existing warnings. Full yarn test:no-watch --runInBand still fails on unrelated existing wallet-admin alias/icon issues and pre-existing launch approval expectations.

What was broken
- Active challenge saves could show a success-only state after an attempted active phase shortening, even when challenge-api kept the original timeline.

Root cause
- The editor reset and navigated with the patch response, which could echo submitted phase dates instead of the persisted schedule state.

What was changed
- Active scheduled challenge saves now refetch the persisted challenge before resetting or navigating.
- Rejected active-phase shortening is detected from the fresh schedule and shown as a partial-save warning while other saved fields remain saved.
- Challenge editor docs were updated for the post-save schedule verification behavior.

Any added/updated tests
- Added a ChallengeEditorForm regression test for a patch response that echoes shortened phase dates while the persisted timeline remains unchanged.
- Validation run: focused PM-5446 test passed; lint passed; build passed with existing warnings. Full yarn test:no-watch --runInBand still fails on unrelated existing wallet-admin alias/icon issues and pre-existing launch approval expectations.
@jmgasper jmgasper requested a review from kkartunov as a code owner June 24, 2026 06:56
@jmgasper jmgasper merged commit 9d5e727 into dev Jun 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant