Fix model load breaking when using unofficial authentication servers on Retro versions of Minecraft - #1006
Open
gizmogoat wants to merge 1 commit into
Open
Fix model load breaking when using unofficial authentication servers on Retro versions of Minecraft#1006gizmogoat wants to merge 1 commit into
gizmogoat wants to merge 1 commit into
Conversation
Author
|
This pull request might need further testing with more vast implementations of skin fixes and with other mods on retro versions of Minecraft, as CPM on these versions introduce a lot more functionality than it seems it would at first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a custom API server for authentication, versions of the mod that use the retro GameProfile implementation break because it is hard-coded to check what the domain name is
Remove the if statement and it works well!
