Skip to content

TINYMCE-14795: Fix mouse reset code - #171

Open
TheSpyder wants to merge 3 commits into
masterfrom
feature/TINYMCE-14795
Open

TINYMCE-14795: Fix mouse reset code#171
TheSpyder wants to merge 3 commits into
masterfrom
feature/TINYMCE-14795

Conversation

@TheSpyder

Copy link
Copy Markdown
Member

Related Ticket: TINYMCE-14795

Description of Changes:

  • We've long had mouse reset code in bedrock, but it had two problems
    1. It was scoped to Chrome browsers
    2. It only activates on test start, so the change in 15.0.0 to reduce network traffic accidentally bypassed it
  • The code is now enabled for all browsers
  • On the client, a wrapper around XHR detects when mouse events are used (our test library doesn't use fetch for this) and sets a flag so the next test sends a start event to reset the mouse
  • to avoid this causing extra spam to the server, the 30s result pings are included in test starts now

This should fix our build failures on Firefox 153, which appears to have changed something about the mouse hover code.

Pre-checks:

  • Changelog entry added
  • package.json versions have not been changed (done by Lerna on release)
  • Tests have been added (if applicable)

Before merging:

  • Ensure internal dependencies are on appropriate versions
    • For stable releases, all dependencies must be stable
    • For release candidates, all dependencies must be release candidates or stable

@TheSpyder
TheSpyder requested a review from a team as a code owner August 21, 2026 07:20
// A global list of requests that were sent to the server, we must wait for these before sending `/done` or it may confuse the HUD
const requestsInFlight: Promise<void>[] = [];

// reset the time for every pull from the results list

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stating the obvious?

if (shouldResetMousePos && mousePositionResetSupported) {
try {
// Park the mouse in the top left corner, out of the way of the browser.
// Use two actions to account for drivers thinking this is a no-op; it still only

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe fix this weird indentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants