TINYMCE-14572: Update dependencies - #170
Open
MitchC1999 wants to merge 12 commits into
Open
Conversation
MitchC1999
requested review from
ArvinJ-H,
TheSpyder,
hamza0867,
kimwoodfield,
ltrouton,
shanmen-tiny,
soritaheng,
spocke and
tiny-ben-tran
August 19, 2026 04:54
TheSpyder
approved these changes
Aug 19, 2026
kimwoodfield
approved these changes
Aug 19, 2026
shanmen-tiny
approved these changes
Aug 19, 2026
TheSpyder
reviewed
Aug 19, 2026
| "chai": "^6.2.2", | ||
| "eslint": "^10.8.1", | ||
| "eslint-config-google": "^0.14.0", | ||
| "esm": "^3.2.25", |
Member
There was a problem hiding this comment.
While we're here, can we try to get rid of esm? It's a bit more than a dependency change but we need to delete it eventually as we have in our other projects.
spocke
approved these changes
Aug 19, 2026
| "ts-loader": "^9.6.2", | ||
| "tsconfig-paths-webpack-plugin": "^4.2.0", | ||
| "webdriverio": "^9.30.1", | ||
| "webpack": "^5.109.2", |
Member
There was a problem hiding this comment.
So we are not removing webpack just not making it default?
Author
There was a problem hiding this comment.
The ticket was just to change the default. We might have webpack hardcoded as the bundler in places. I can make this a follow up
| "patch-package": "^8.0.1", | ||
| "rimraf": "^6.1.3", | ||
| "ts-node": "^10.9.2", | ||
| "typescript": "^6.0.3" |
Author
There was a problem hiding this comment.
I remember a discussion around migrating away from eslint since they aren't planning to support TS 7? Perhaps this should be part of a follow up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Ticket: TINYMCE-14572, TINYMCE-14649
Description of Changes:
Pre-checks:
Tests have been added (if applicable)Before merging: