Fix for rails 8.1#291
Closed
cub8 wants to merge 2 commits into
Closed
Conversation
Author
|
Just realized that first, it's the case with shoulda-matchers and not shoulda and there's already way around this problem: thoughtbot/shoulda-context#109 Sorry for causing chaos 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Rails 8.1 updated class
executableattribute definition inRails::TestUnitReporter:As a consequence, when tests failed there would be a nasty error because Shoulda used
executableaccessor instead ofself.class.executable.Fix
executablecall toself.class.executable. This works becauseclass_attribute :executableallows bothself.class.executablecall on singleton class andexecutableon class instance