[SDK] Feature: add Vultisig to extra wallets - #8911
Conversation
Adds an EIP-6963 injected entry (rdns me.vultisig) plus its icon, and regenerates src/wallets/__generated__.
🦋 Changeset detectedLatest commit: 43590f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@realpaaao is attempting to deploy a commit to the thirdweb Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (270)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughThe PR adds Vultisig to the extra-wallets registry and records a patch release for the ChangesVultisig wallet support
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change adds Vultisig as an injected wallet and updates generated wallet metadata; the reported generation, type-check, and wallet tests pass, so no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adds Vultisig to
extra-wallets.jsonso it shows up in the connect UI as an injected wallet.Vultisig is a seedless, self-custodial multi-chain wallet secured by MPC threshold signatures. The browser extension implements EIP-6963 with rdns
me.vultisig, which is what this entry hooks into.Changes
scripts/wallets/extra-wallets.json— new entry,rdns: "me.vultisig"scripts/wallets/extra-wallet-icons/vultisig.svg— icon (square, 1024 viewBox, no text)src/wallets/__generated__/**— output ofpnpm build:generate-walletsNotes for the reviewer
extra-wallets.jsonroute.mobileanddesktopare intentionallynull— this is an extension/EIP-6963 integration only, no WalletConnect pairing. The entry lands inInjectedSupportedWalletIdsand stays out ofWCSupportedWalletIds.app.ios/app.androidare store links for the download screen only; there is no mobile connection path here.__generated__diff is large because the script refetches the upstream WalletConnect listing. Onlyme.vultisigis intentional; the rest is registry drift.How to test
pnpm build:generate-walletsinpackages/thirdweb, then confirmme.vultisigappears inInjectedSupportedWalletIdsinsrc/wallets/__generated__/wallet-ids.tsand thatsrc/wallets/__generated__/wallet/me.vultisig/containsindex.tsandimage.ts.receipts
Generator (
packages/thirdweb):me.vultisiglands in the injected set only — counted per exported type block insrc/wallets/__generated__/wallet-ids.ts:Icon rasterizes through the same sharp path the script uses (128x128 webp, 2016 bytes); decoded the emitted base64 from
image.tsand confirmed the mark renders.Type-check:
Biome on the regenerated tree:
Warnings only, all pre-existing classes (the generated files carry
biome-ignore-all);mainreports the same at 995 files / 501 warnings.Wallet test suite:
src/wallets/in-app/web/lib/auth/redirect-state.test.tsxis excluded above because it fails identically on unmodifiedmainin my environment (Cannot read properties of undefined (reading 'clear')) — unrelated to this change.Links: https://vultisig.com · https://github.com/vultisig
Summary by CodeRabbit
New Features
Chores