audio: copier: avoid IRQ lock/unlock in chmap code#10972
Open
kv2019i wants to merge 1 commit into
Open
Conversation
Copier set_chmap() blocks IRQs to atomically update the converters. This code is not safe to be moved to user-space, so replace the locks with calls to block LL scheduler execution. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
jsarha,
lgirdwood,
lyakh,
serhiy-katsyuba-intel and
wjablon1
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the copier channel-map update path to avoid disabling/enabling IRQs when building with user-space LL scheduling, switching to the LL scheduler’s per-core lock for atomic updates of converter function pointers and channel maps.
Changes:
- Add LL scheduler domain header to access
user_ll_lock_sched()/user_ll_unlock_sched(). - Use LL scheduler locking in
set_chmap()underCONFIG_SOF_USERSPACE_LL, otherwise keep the IRQ disable/enable path.
Comment on lines
13
to
17
| #include <rtos/interrupt.h> | ||
| #include <sof/ipc/msg.h> | ||
| #include <sof/ipc/topology.h> | ||
| #include <sof/schedule/ll_schedule_domain.h> | ||
| #include <rtos/interrupt.h> |
Collaborator
Author
There was a problem hiding this comment.
Not part of this PR.
Collaborator
Author
|
For context, related to #10558 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copier set_chmap() blocks IRQs to atomically update the converters. This code is not safe to be moved to user-space, so replace the locks with calls to block LL scheduler execution.