Skip to content

fix(deploy): add type: docs and storybook-projects to deploy.yml - #228

Merged
iamnewton merged 2 commits into
mainfrom
fix/deploy-workflow
Aug 15, 2026
Merged

fix(deploy): add type: docs and storybook-projects to deploy.yml#228
iamnewton merged 2 commits into
mainfrom
fix/deploy-workflow

Conversation

@iamnewton

Copy link
Copy Markdown
Contributor

The deploy.yml was missing the required type input and had no storybook-projects, leaving the deploy job broken. Fixes both:

  • type: docs — required by the reusable workflow; builds and deploys the Astro docs site from docs/dist/
  • storybook-projects — deploys Storybook alongside docs; uses YAML block scalar (>-) to avoid single-quote parsing issues that were silently dropping the with: block

Storybook lands at /sandbox/storybook/. A follow-up will update the viteFinal base path to match.

Signed-off-by: Newton <5769156+iamnewton@users.noreply.github.com>
@iamnewton
iamnewton requested a review from a team as a code owner August 15, 2026 00:24
Signed-off-by: Newton <5769156+iamnewton@users.noreply.github.com>
@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #228   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files           6        6           
  Lines          87       87           
  Branches       11       11           
=======================================
  Hits           83       83           
  Misses          2        2           
  Partials        2        2           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iamnewton
iamnewton merged commit 6272e89 into main Aug 15, 2026
36 checks passed
@iamnewton
iamnewton deleted the fix/deploy-workflow branch August 15, 2026 00:38
@iamnewton

Copy link
Copy Markdown
Contributor Author

🎉 This PR is included in version 0.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamnewton iamnewton added the released Included in a release label Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant