Support SLH-DSA server keys - #3120
Merged
Merged
Conversation
This commit adds support for server certificates that have SLH-DSA public keys. The code points come from https://datatracker.ietf.org/doc/draft-reddy-tls-slhdsa/. These code points were added to OpenSSL 4.1.0-dev by openssl/openssl#31248.
Collaborator
|
Thanks a lot, @dcooper16 !! The elif statements around L8570 and L9445 became a little ugly, if you want and have the opportunity a case statement would be more clean. |
dcooper16
added a commit
to dcooper16/testssl.sh
that referenced
this pull request
Aug 15, 2026
This commit cleans up PR testssl#3120. It replaces two long "if" statements with "case" statements and it removes a second declaration of "nr_cert_types" in run_server_defaults().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for server certificates that have SLH-DSA public keys. The code points come from https://datatracker.ietf.org/doc/draft-reddy-tls-slhdsa/. These code points were added to OpenSSL 4.1.0-dev by openssl/openssl#31248.
What is your pull request about?
If it's a code change please check the boxes which are applicable
help()AI section
[e.g. GPT-A.B, Claude <NAME> A.B, Gemini A.B <NAME>, Qwen<B>-Coder, DeepSeek-<A> etc.][e.g. GitHub CoPilot, JetBrains Junie, VS Code plugin <NAME> etc.][e.g. GPT-A.B, Claude <NAME> A.B, Gemini A.B <NAME>, Qwen<B>-Coder, DeepSeek-<A> etc.]