iOS: make requestDeviceCameraAuthorization actually request authorization - #803
Open
ZayanKhan-12 wants to merge 1 commit into
Open
iOS: make requestDeviceCameraAuthorization actually request authorization#803ZayanKhan-12 wants to merge 1 commit into
ZayanKhan-12 wants to merge 1 commit into
Conversation
…tion The requestDeviceCameraAuthorization ref method called NativeCameraKitModule.checkDeviceCameraAuthorizationStatus() - a copy-paste of the checkDeviceCameraAuthorizationStatus method directly below it. Calling it returned the current authorization status without ever presenting the iOS permission prompt. The native side already implements the request path (RNCameraKitModule.mm -> CameraManager.requestDeviceCameraAuthorization) and the TurboModule spec declares it; it was just never called from JS. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
requestDeviceCameraAuthorizationref method calls the wrong native method — a copy-paste ofcheckDeviceCameraAuthorizationStatusdirectly below it:So calling
requestDeviceCameraAuthorization()returns the current status without ever presenting the iOS permission prompt.The native request path exists and is wired: the TurboModule spec declares
requestDeviceCameraAuthorization(src/specs/NativeCameraKitModule.ts),RNCameraKitModule.mmforwards it, andCameraManager.swiftimplements it — it was just never called from JS.Fix
One line: call
NativeCameraKitModule.requestDeviceCameraAuthorization().(I realize the README marks the permission APIs as deprecated, but the method is still part of the exported
CameraApitype, so while it exists it should do what its name says.)🤖 Generated with Claude Code