ci: declare contents:read on nightly wheels workflow#101
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
The nightly build_wheels job only checks out, configures bazel, runs pypa/cibuildwheel, and uploads the resulting wheels as artifacts. No GitHub API write beyond actions/checkout. contents:read is the floor. Style matches the per-job permissions block already in build.yml (id-token:write for trusted publishing). ci-lint.yml is only 21 lines and left out of this PR. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
arpitjain099
force-pushed
the
chore/nightly-permissions
branch
from
June 10, 2026 07:21
999fe36 to
b9f9186
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly
Build tfx-bsl Nightlyworkflow builds wheels for the cp310-cp313 / ubuntu+macos matrix viapypa/cibuildwheel@v2.23.3and uploads them asactions/upload-artifactartifacts. No GitHub API write (artifact upload in v4 doesn't require explicit permissions), no comment on PRs, no push to the repo.This patch sets
permissions: contents: readat workflow scope. It matches the per-job permission block already inbuild.yml(id-token: writefor trusted publishing of the release wheels) -- both workflows now declare the minimum the steps actually use.With explicit scope:
Token-Permissionscheck passes for this filepypa/cibuildwheeloractions/upload-artifact(cf. tj-actions/changed-files CVE-2025-30066) stays boxed in read-only.ci-lint.ymlis the other workflow that doesn't declare permissions, but it's 21 lines and below the noise floor for a separate PR.No behavioural change.