[tfjs-node] Prevent tensor ID rollover leaks and collisions - #8739
Open
GideonKoenig wants to merge 1 commit into
Open
[tfjs-node] Prevent tensor ID rollover leaks and collisions#8739GideonKoenig wants to merge 1 commit into
GideonKoenig wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8735.
Summary
tfjs-nodeassigns native tensor handles signed 32-bit IDs. When the counter reachesINT32_MAX, the current implementation relies on signed overflow and begins returning negative IDs.This causes two problems:
NodeJSKernelBackend.disposeData()only deletes IDs greater than or equal to zero, so native handles allocated after rollover are leaked.unordered_map::insertresult is returned without checking whether insertion succeeded, which can alias the new JavaScript tensor to the persistent tensor's native handle.Disposing the temporary tensor can then delete the persistent tensor's handle.
Changes
This PR:
INT32_MAXtoINT32_MINtransition, avoiding signed-overflow behavior;-1, which is already used to represent tensor data that has not been uploaded to the native backend;disposeData()to delete negative native tensor IDs while continuing to exclude the-1sentinel;tfe_handle_map_.emplace()successfully inserted the new handle;setNextTensorIdForTest()binding hook for deterministic rollover and collision coverage. This is not added to the publicTFJSBindingTypeScript interface.In the normal allocation path,
emplace()performs the same map lookup needed for insertion. Additional attempts occur only when an occupied ID is encountered.Testing
Added coverage for:
INT32_MAXrolling over toINT32_MIN;-1ID;Local validation under Node.js 20.20.2:
tfjs-nodesuite: 4,045 specs, 0 failures, 5 existing pending specs;tfjs-nodelint passed;