fix(cloud-nav): smooth label fade on side-nav collapse/expand#3628
Open
bilal-karim wants to merge 1 commit into
Open
fix(cloud-nav): smooth label fade on side-nav collapse/expand#3628bilal-karim wants to merge 1 commit into
bilal-karim wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bilal-karim
force-pushed
the
cloud-nav-label-fade
branch
from
2cbcc5f to
abf6a03
Compare
Follow-up to #3606. The nav item labels used a plain symmetric opacity transition, so on collapse they stayed opaque as the panel narrowed over them (a visible "chop") and expand/collapse felt abrupt. Make the label motion direction-aware and paired with the nav's 150ms transition-width, scoped to the Cloud nav via a new data-cloud attribute (OSS unchanged): - Collapse: the label leads — a fast 75ms ease-out fade so it clears before the shrinking panel reaches it. - Expand: the label lags — waits 75ms for the panel to open, then fades in linearly over 150ms. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
bilal-karim
force-pushed
the
cloud-nav-label-fade
branch
from
abf6a03 to
2c549ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3606.
Problem
The Cloud side-nav item labels used a plain symmetric
opacitytransition. On collapse they stayed opaque while the panel narrowed over them (a visible "chop"), and expand/collapse felt abrupt (see Standalone Activities and Namespace Settings as an example).Change
Direction-aware label motion, paired with the nav's existing 150ms
transition-width, scoped to the Cloud nav only (OSS unchanged). The panel width moves continuously in both directions (no stall); the label transitions on the roomy side of the width change:ease-outfade so it clears before the shrinking panel reaches it.Before.mp4
After.mp4
Implementation
data-cloudattribute on the nav container — mirrors the existingdata-navpattern the labels already read viagroup-data-[nav=…].navigation-item.svelte, each scoped to Cloud + nav state; the OSS nav resolves to its original opacity-only transition.Diff: 2 files, +2/−1.
Testing
Verified against the real cloud-ui CSS bundle:
🤖 Generated with Claude Code