Draft fix for link variant handling#3620
Open
VegetarianOrc wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![temporal-cicd[bot]](https://avatars.githubusercontent.com/in/357945?s=60&v=4){kind=small}
| const callbackLinks = $derived(links.length ? links : link ? [link] : []); | ||
| const linkViews = $derived(toEventLinkViews(callbackLinks, { namespace })); | ||
| </script> | ||
|
|
Contributor
There was a problem hiding this comment.
⚠️ Parameter 'view' implicitly has an 'any' type.
| <th>{translate('nexus.caller-link')}</th> | ||
| <th>{translate('nexus.caller-namespace')}</th> | ||
| <th>{translate('nexus.handler-event')}</th> | ||
| </TableHeaderRow> |
Contributor
There was a problem hiding this comment.
⚠️ 'event' is possibly 'undefined'.
| <th>{translate('nexus.handler-event')}</th> | ||
| </TableHeaderRow> | ||
| {#each inboundLinkEvents as event} | ||
| {#each inboundLinkEvents as event (event.id)} |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'WorkflowExecutionStartedEvent | WorkflowExecutionOptionsUpdatedEvent | undefined' is not assignable to parameter of type 'WorkflowEvent'.
| </TableHeaderRow> | ||
| {#each inboundLinkEvents as event} | ||
| {#each inboundLinkEvents as event (event.id)} | ||
| {@const link = getInboundLinkForEvent(event)} |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'false | ILink | undefined' is not assignable to parameter of type 'ILink | undefined'.
Contributor
|
rossedfort
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
This PR shows some changes made using codex to handle the new nexusOperation link variant in various display scenarios. Codex attempted to generalize the solution to handle future variants.
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?