fix(release): bump pinned ko/koparse image for go 1.26.4#3689
Open
jkhelil wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3689 +/- ##
==========================================
- Coverage 24.49% 24.48% -0.01%
==========================================
Files 470 470
Lines 24919 24924 +5
==========================================
- Hits 6103 6102 -1
- Misses 18122 18126 +4
- Partials 694 696 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
/retest |
tekton/build-publish-images-manifests.yaml pinned the ko/kustomize build steps to ko-gcloud:v20240920-6c2a999d36, which ships Go 1.22.1. go.mod now requires go 1.26.4 (CVE-2026-27145 stdlib fix), and no ko-gcloud digest published yet ships Go >= 1.26.4. Switch those steps to the plain ko image instead, which already ships Go 1.26.4 and includes every tool they actually use (ko, kustomize, git) without needing the gcloud/kubectl/yq extras that ko-gcloud bundles. Also bump the koparse step to its current digest. Add a dependabot docker ecosystem entry for /tekton so these pinned image digests are kept in sync with go.mod going forward, instead of silently drifting behind the required Go toolchain version. Signed-off-by: Jawed khelil <jkhelil@redhat.com> Assisted-by: Claude Sonnet 4.5 (via Cursor) Co-authored-by: Cursor <cursoragent@cursor.com>
tektoncd/pipeline's own release pipeline (tekton/publish.yaml) pins the same ko image for this step, at go1.26.4. Use their exact digest instead of a separately-picked one, so both projects stay in sync. Signed-off-by: Jawed khelil <jkhelil@redhat.com> Assisted-by: Claude Sonnet 4.5 (via Cursor) Co-authored-by: Cursor <cursoragent@cursor.com>
2fe3f8f to
5709594
Compare
vdemeester
approved these changes
Jul 10, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ko v0.19.0 enforces that kodata symlinks must not resolve outside the kodata root (ko-build/ko#1619). The run-kustomize-ko step symlinks cmd/${KUBE_DISTRO}/*/kodata/source.tar.gz to a file in an external tmpdir, which the newly-pinned ko v0.19.1 image now rejects, breaking release image publishing. Copy the tarball into each kodata/ directory instead. ko already dereferences symlinks when tarring kodata, so this has no effect on final image size. Signed-off-by: Jawed khelil <jkhelil@redhat.com> Assisted-by: Claude Sonnet 5 (via Cursor) Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
tekton/build-publish-images-manifests.yamlpinned the ko/kustomizebuild steps to
ghcr.io/tektoncd/plumbing/ko-gcloud:v20240920-6c2a999d36,which ships Go 1.22.1.
go.modnow requiresgo 1.26.4(CVE-2026-27145stdlib fix), and no
ko-gclouddigest published yet ships Go >= 1.26.4.rewrite-devel-in-sourceandrun-kustomize-kosteps tothe plain
koimage instead, which already ships Go 1.26.4 andincludes every tool they actually use (
ko,kustomize,git)without needing the gcloud/kubectl/yq extras that
ko-gcloudbundles.koparsestep to its current digest.dockerpackage-ecosystem entry for/tektonto.github/dependabot.config.yml(regenerated.github/dependabot.ymlvia
./hack/generate-dependabot.sh) so these pinned image digests arekept in sync with
go.modgoing forward instead of silently driftingbehind the required Go toolchain version.
Verified by pulling both the old and new images and confirming
go versioninside each, and that the newkoimage hastar,sed,awk,git,kustomize, andkoavailable.Follow-up fix: kodata symlink rejected by ko >= v0.19
The
koimage now pinned here (aligned withtektoncd/pipeline's digest)ships
kov0.19.1, which enforces thatkodata/symlinks must not resolveoutside the kodata root (ko-build/ko#1619). The
run-kustomize-kostepsymlinks
cmd/${KUBE_DISTRO}/*/kodata/source.tar.gzto a tarball in anexternal
mktemp -ddirectory, which this newerkonow rejects:We hit this exact failure in
tektoncd/chains' release pipeline after asimilar Go 1.26.4-driven
kodigest bump(tektoncd/chains#1791),
and the same unfixed pattern also exists upstream in
tektoncd/pipeline'stekton/publish.yaml(tektoncd/pipeline#10418).
Since this PR moves operator onto the same
kov0.19.1 digest, it would hitthe identical error on the next real release, so the fix is included here.
Fix: copy the tarball into each
cmd/${KUBE_DISTRO}/*/kodata/directoryinstead of symlinking to it from a shared tmpdir.
koalready dereferencessymlinks and embeds the resolved file's bytes into the image layer when
tarring kodata, so this has no effect on final image size — only the
symlink itself was rejected, not the underlying content.
Submitter Checklist
make test lintbefore submitting a PRRelease Notes
Made with Cursor