Skip to content

ci(coverage): include pkg/apis in Codecov coverage tracking#3686

Merged
tekton-robot merged 1 commit into
tektoncd:mainfrom
jkhelil:fix/codecov-include-pkg-apis
Jul 9, 2026
Merged

ci(coverage): include pkg/apis in Codecov coverage tracking#3686
tekton-robot merged 1 commit into
tektoncd:mainfrom
jkhelil:fix/codecov-include-pkg-apis

Conversation

@jkhelil

@jkhelil jkhelil commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Changes

Fix a missed exclusion from the Codecov configuration added in #3684.

pkg/apis/ was incorrectly excluded from coverage tracking. Unlike
pkg/client/ (which is entirely generated), pkg/apis/ contains 38
handwritten test files covering validation, lifecycle, and defaults
logic — all of which should be tracked.

What changes:

  • Remove pkg/apis/** from the .codecov.yaml ignore list
  • Keep pkg/client/** excluded (0 test files, 100% generated code)
  • The one generated file in pkg/apis/ (zz_generated.deepcopy.go)
    remains excluded via the existing **/zz_generated*.go pattern

Submitter Checklist

  • Run make test lint before submitting a PR
  • Includes tests (if functionality changed/added) — config-only change
  • Includes docs (if user facing) — not user facing
  • Commit messages follow commit message best practices

Release Notes

NONE

Made with Cursor

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jul 8, 2026
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 8, 2026
@codecov-commenter

codecov-commenter commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 24.49%. Comparing base (6ce06ca) to head (509f41f).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3686   +/-   ##
=======================================
  Coverage   24.49%   24.49%           
=======================================
  Files         470      470           
  Lines       24919    24919           
=======================================
  Hits         6103     6103           
  Misses      18122    18122           
  Partials      694      694
Flag Coverage Δ
unit-tests 24.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tekton-robot

tekton-robot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2026
infernus01
infernus01 reviewed Jul 9, 2026
View reviewed changes

@infernus01 infernus01 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. but, there was one more comment from Emil on the previous PR - #3684 (review)

@jkhelil @cursoragent
ci(coverage): include pkg/apis in coverage tracking
509f41f 
pkg/apis contains 38 handwritten test files covering validation,
lifecycle, and defaults logic — it should not be excluded.

Only pkg/client is excluded as it is entirely generated code
with no test files. The single generated file in pkg/apis
(zz_generated.deepcopy.go) is already excluded by the
existing **/zz_generated*.go pattern.

Signed-off-by: Jawed khelil <jkhelil@redhat.com>
Assisted-by: Claude Sonnet 4.6 (via Cursor)
Co-authored-by: Cursor <cursoragent@cursor.com>
@jkhelil jkhelil force-pushed the fix/codecov-include-pkg-apis branch from a710260 to 509f41f Compare July 9, 2026 09:50
@jkhelil

jkhelil commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

@enarha @infernus01 it is now fixing issue raised. y Emil

enarha
enarha reviewed Jul 9, 2026
View reviewed changes

@enarha enarha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2026
@tekton-robot tekton-robot merged commit b7677e8 into tektoncd:main Jul 9, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enarha enarha enarha left review comments
@vdemeester vdemeester vdemeester approved these changes
@pramodbindal pramodbindal Awaiting requested review from pramodbindal
@pratap0007 pratap0007 Awaiting requested review from pratap0007
+1 more reviewer
@infernus01 infernus01 infernus01 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@enarha enarha

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jkhelil @codecov-commenter @tekton-robot @vdemeester @enarha @infernus01