remove TektonHub component support#3494
Conversation
|
@pratap0007 Please review |
|
I hope I didnt miss any place. if there are additional tests I need to run to make sure nothing breaks let me know. I only ran locally what runs in the CI |
|
/meow |
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
tested upgrading patht and got: |
| return c | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
can we revert this file changes?
|
Thanks @ngelman1 for the PR and it looks good to me. I have just a few suggestions, please review them and address them if needed. |
|
/lgtm |
|
New changes are detected. LGTM label has been removed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3494 +/- ##
==========================================
+ Coverage 24.48% 25.51% +1.03%
==========================================
Files 470 448 -22
Lines 24924 23309 -1615
==========================================
- Hits 6102 5948 -154
+ Misses 18126 16675 -1451
+ Partials 696 686 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anithapriyanatarajan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ngelman1 can you rebase , and we can merge |

Changes
Resolves SRVKP 11797
Remove all TektonHub CRD, controller, and related code from the operator due to Hub deprication.
code removed:
TektonHubCRD definition and generated CRD manifestsTektonHubAPI types, defaults, validation, and lifecycleoperatorhub/openshift/config.yamlTektonHub.md, air-gap image table rows, TektonConfig hub params)fetch-releases.shhub release fetching logic(made sure build lint and test passed before submitting)
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes