Skip to content

remove TektonHub component support#3494

Open
ngelman1 wants to merge 1 commit into
tektoncd:mainfrom
ngelman1:remove-hub
Open

remove TektonHub component support#3494
ngelman1 wants to merge 1 commit into
tektoncd:mainfrom
ngelman1:remove-hub

Conversation

@ngelman1

Copy link
Copy Markdown
Contributor

Changes

Resolves SRVKP 11797
Remove all TektonHub CRD, controller, and related code from the operator due to Hub deprication.

code removed:

  • TektonHub CRD definition and generated CRD manifests
  • TektonHub API types, defaults, validation, and lifecycle
  • Kubernetes and OpenShift TektonHub reconcilers/controllers
  • Hub-related entries from TektonConfig spec and validation
  • Generated client code (clientset, informers, listers, injection)
  • OLM bundle/CSV references (owned CRDs, container images, env vars)
  • Helm chart CRD templates and controller args
    • Hub image entries from operatorhub/openshift/config.yaml
  • Documentation (TektonHub.md, air-gap image table rows, TektonConfig hub params)
  • E2E tests, test helpers, and test data for TektonHub
  • fetch-releases.sh hub release fetching logic
  • Static kodata (PostgreSQL ConfigMap)

(made sure build lint and test passed before submitting)

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jun 15, 2026
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 15, 2026
@jkhelil

jkhelil commented Jun 15, 2026

Copy link
Copy Markdown
Member

@pratap0007 Please review

@ngelman1

Copy link
Copy Markdown
Contributor Author

I hope I didnt miss any place. if there are additional tests I need to run to make sure nothing breaks let me know. I only ran locally what runs in the CI

@vdemeester

Copy link
Copy Markdown
Member

/meow

@tekton-robot

Copy link
Copy Markdown
Contributor

@vdemeester: cat image

Details

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2026
@tekton-robot tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 23, 2026
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 24, 2026
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2026
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2026
@ngelman1

ngelman1 commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

tested upgrading patht and got:
admission webhook \"[webhook.operator.tekton.dev](http://webhook.operator.tekton.dev/)\" denied the request: mutation failed: cannot decode incoming old object: json: unknown field \"hub\""
at first.
Now added back the type and removeHubFromTektonConfig to pre-upgrade. loogs looks good now when upgrading. will be safe to completely remove next release.
{"level":"info","msg":"Reconcile succeeded","knative.dev/controller":"...tektonconfig.Reconciler","knative.dev/key":"config","duration":1.064538652}

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2026
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2026
Comment thread pkg/reconciler/proxy/controller.go Outdated
return c
}


Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we revert this file changes?

Comment thread pkg/reconciler/shared/tektonconfig/upgrade/pre_upgrade.go
Comment thread pkg/reconciler/shared/tektonconfig/upgrade/pre_upgrade.go
@pratap0007

Copy link
Copy Markdown
Contributor

Thanks @ngelman1 for the PR and it looks good to me. I have just a few suggestions, please review them and address them if needed.

@pratap0007

Copy link
Copy Markdown
Contributor

/lgtm

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 7, 2026
@tekton-robot

Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2026
@codecov-commenter

codecov-commenter commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.51%. Comparing base (477bca6) to head (1974c55).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3494      +/-   ##
==========================================
+ Coverage   24.48%   25.51%   +1.03%     
==========================================
  Files         470      448      -22     
  Lines       24924    23309    -1615     
==========================================
- Hits         6102     5948     -154     
+ Misses      18126    16675    -1451     
+ Partials      696      686      -10     
Flag Coverage Δ
unit-tests 25.51% <ø> (+1.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anithapriyanatarajan

Copy link
Copy Markdown
Contributor

/approve

@tekton-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anithapriyanatarajan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [anithapriyanatarajan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2026
@jkhelil

jkhelil commented Jul 10, 2026

Copy link
Copy Markdown
Member

@ngelman1 can you rebase , and we can merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants