Expose coredump check artifacts from guest-side collection - #5100
Open
saisharan0103 wants to merge 1 commit into
Open
Conversation
…core dumps in results Closes teemtee#5088
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The coredump check was collecting crash reports and core files on the guest during after-test checks, then discovering result log entries by running
findover the shared checks directory and filtering each path with runner-sidePath.exists(). Because that happened before the second post-check pull copied the newly created guest files back, collected coredump files were dropped from results. The same discovery path could also include files owned by other checks that had already been pulled and publish the internalcoredump-latestmarker.This changes
_get_crashesto track the exact report and core paths it creates and return them with the non-ignored crash records._check_coredumpnow converts only those owned paths to paths relative toinvocation.phase.step_workdir, appendsfailures.yaml, and no longer usesfindplus runner-side existence checks for result discovery.The
dump.*.txtcommand also now invokescoredumpctl infodirectly instead of through an invalidsh -cwrapper, preservingsudo, options, PID, and redirection so the saved text file contains details for the selected crash.ruff check tests/test/check/test-coredump.sh tmt/checks/coredump.pyreports no new findings on the changed files.Ran
pytest -xlocally with no new failures.