Add RISC-V support for testcloud provision - #4964
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds support for the riscv64 architecture in the tmt schemas and the testcloud provisioner. The feedback suggests sorting the imported classes alphabetically in tmt/steps/provision/testcloud.py to maintain PEP 8 compliance.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
8d72c60 to
d279441
Compare
|
/packit build |
|
Given the dependency on a particular (unreleased) version of testcloud, should we add also a minimal version constraint to the specfile? Combining this tmt version and any testcloud version will not work correctly. |
Oh boy, do you want to do the copr build dependency dance? We are in the issue of multiple python version dependency in different Fedora releases |
I'm not sure I follow, or at least I don't understand what kind of "dance" would this be. I'm asking because unless I misunderstand something, I see the following two issues:
TL;DR, there's a library that will add a functionality, and there's an app that requires said functionality to build new feature on top of it. It's certainly possible to package the app without requiring the library be of version that provides the functionality, or newer, but doesn't that spell breakage in possibly many environments, lowering the user experience? |
I am not saying that we should not add the requirement restriction, just that we have to figure out the order of copr when we do so. Remember the fmf issue we had a few weeks prior |
Hm, I guess "Oh boy, do you want to do the copr build dependency dance?" fooled me then, I took it as a rather sarcastic way of questioning the idea of adding a versioned requirement.
Sure.
Wasn't that complicated by fmf also depending on tmt for some reason? |
|
If using a testcloud version without teemtee/testcloud#29, it'll fail with: Updated the minimum testcloud version to 0.11.9 in pyproject.toml and tmt.spec (assuming teemtee/testcloud#29 will be merged in 0.11.9) |
3f3f777 to
5b93ab3
Compare
5b93ab3 to
ad6d299
Compare
Depend on: teemtee/testcloud#29
Pull Request Checklist