Switch to using fmf.ContextDimension - #4894
Conversation
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
LecrisUT
added
status | blocked
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a custom TmtContext to replace the standard fmf.context.Context, updating dependencies to fmf>=1.8.0 and adjusting various components to use the new implementation. Feedback focuses on ensuring the new context correctly inherits from DistroContext and maintains standard dimension matching logic. Specifically, TmtContextDimension should not redefine _registrar as it hides standard dimensions like arch and distro, and TmtContext should inherit from DistroContext to leverage distribution-aware logic. Additionally, the uv-pre-commit hooks should not be commented out, and the new context plugin registry requires proper integration with the fmf dimensions registrar to function.
|
/packit build |
LecrisUT
changed the title
fmf.DistroContextfmf.ContextDimension
LecrisUT
removed
the
status | blocked
2 participants
Depends-on teemtee/fmf#293