fix(ci): upgrade Actions to v5 and unblock CI install/audit gates#72
Merged
Conversation
GitHub now runs Node 24 on runners, deprecating Node-20-based action releases. Bump checkout/setup-node/cache/upload-artifact to v5, align CLI React with ink@7 for fresh npm installs on CI, hoist ink/react for Vitest, and ignore transitive quick-xml advisories from plist until upstream updates. Co-authored-by: Cursor <cursoragent@cursor.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_78562181-688a-43a2-ac35-9293532de0dc) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/checkout,setup-node,cache, andupload-artifactfrom v4 → v5 so workflows run natively on Node 24 (fixes the deprecation warnings/failures GitHub started enforcing)reactto ^19.2.0 to satisfyink@7peer deps — this was the real cause of yesterday'snpm installERESOLVE failures in CodeQL / Dependency Security / Release Gateink+reactdevDependencies so Vitest can resolve Ink TUI tests on a fresh CI install.cargo/audit.tomlto ignore transitivequick-xmladvisories pulled in viaplist → tauriuntil upstream adopts>=0.41Root cause
The Node 20 deprecation message was a warning on v4 actions. The workflows actually failed because:
npm installcould not resolveink@7(needs react >=19) vs CLIreact@18cargo auditflaggedquick-xml 0.39.xfrom Tauri'splistdependencyTest plan
npm install --ignore-scriptssucceeds on a clean treenpx vitest run— 257 passed / 3 failed (pre-existing flaky Ink prompt tests)Made with Cursor