chore(envs): migrate react components from teambit.react/react to react-env - #10642
Open
davidfirst wants to merge 1 commit into
Open
chore(envs): migrate react components from teambit.react/react to react-env#10642davidfirst wants to merge 1 commit into
davidfirst wants to merge 1 commit into
Conversation
PR Summary by QodoMigrate React components to the Rspack-based React environment
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can copy the agent prompt from any finding and feed it to your IDE agent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The core
teambit.react/reactenv bundles component previews with webpack. Theteambit.react/react-env@2.0.3env bundles them with Rspack. Rspack uses less memory and less time in CI builds.Changes
teambit.react/reacttoteambit.react/react-env@2.0.3withbit env replace. The change adds an explicit env entry to each component in.bitmap.pnpm-lock.yamldiff is the dependency churn from the env switch.Verification
use-bulk-paged-query) has a pre-existing tester error. Its spec imports a.jspath that jest cannot resolve. This error is not related to this change.npm run lint(tsc + oxlint) passes.bit buildof a migrated component ran the Rspack bundler in theGeneratePreviewtask and completed all tasks.Replaces #10467, which did the same migration against
react-env@2.0.0.