-
Notifications
You must be signed in to change notification settings - Fork 963
fix(ui): keep component tabs and use-package tabs reachable on mobile in minimal mode #10607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e4818bb
fix(ui): keep component tabs and use-package tabs reachable on mobile…
luvkapur 384c147
fix(ui): lay out the empty-workspace state for narrow viewports
luvkapur cd193eb
Merge branch 'master' into fix/mobile-friendly-workspace-ui
luvkapur 455c645
Merge branch 'master' into fix/mobile-friendly-workspace-ui
github-actions[bot] 849f4e6
Merge branch 'master' into fix/mobile-friendly-workspace-ui
github-actions[bot] 1c4be80
Merge branch 'master' into fix/mobile-friendly-workspace-ui
luvkapur 022b375
Merge branch 'master' into fix/mobile-friendly-workspace-ui
github-actions[bot] e02325c
Merge branch 'master' into fix/mobile-friendly-workspace-ui
github-actions[bot] dbe4d43
Merge branch 'master' into fix/mobile-friendly-workspace-ui
luvkapur b6e124b
Merge branch 'master' into fix/mobile-friendly-workspace-ui
luvkapur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,51 @@ | |
| min-width: 0; | ||
| } | ||
|
|
||
| // Minimal mode, mobile: one 46px row can't fit breadcrumb + nav tabs + pinned widgets + | ||
| // version dropdown, and since only the nav can shrink, ResponsiveNavbar collapses every tab | ||
| // (Overview / Preview) into an overflow dropdown that itself gets clipped — leaving no way to | ||
| // reach the preview. `display: contents` promotes this bar's children into the workspace | ||
| // top bar's wrapping flex row (see workspace.module.scss), producing two rows: | ||
| // back + breadcrumb + pinned widgets + right-side actions, then the nav tabs at full width. | ||
| .topBarMinimal { | ||
| @media screen and (max-width: $br-md) { | ||
| display: contents; | ||
|
|
||
| > .leftSide { | ||
| order: 10; | ||
| flex: 1 0 100%; | ||
| box-sizing: border-box; | ||
| height: 40px; | ||
| overflow-x: auto; | ||
|
Comment on lines
+32
to
+35
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 1. Tabs row too short In minimal mobile mode, the component nav tabs row is forced to 40px height, which reduces the clickable/tappable area of each tab because the tab list items and ResponsiveNavbar are sized to 100% height of that row. This can make navigation harder to use on touch devices and is inconsistent with the workspace topbar’s 46px minimal height. Agent Prompt
|
||
| padding: 0 8px 0 4px; | ||
|
|
||
| // ResponsiveNavbar hides any tab that doesn't fit its container and reserves extra room | ||
| // for its "…" overflow button. Sizing the nav to its content makes the width check always | ||
| // pass (the row scrolls instead), and the now-useless overflow button is dropped so its | ||
| // reserved width can't hide the last tab. | ||
| nav { | ||
| min-width: max-content; | ||
|
|
||
| > div:last-child { | ||
| display: none; | ||
| } | ||
|
luvkapur marked this conversation as resolved.
|
||
| } | ||
| } | ||
|
|
||
| // the pinned widgets carry an inline `height: 100%`, which in the wrapped two-row bar | ||
| // resolves against the full (two-row) height and inflates the first row until the nav row | ||
| // is pushed outside the bar, over the page content — pin every first-row item to the bar | ||
| // height instead | ||
| > :not(.leftSide) { | ||
| height: 46px !important; | ||
| } | ||
|
luvkapur marked this conversation as resolved.
|
||
|
|
||
| > .rightSide { | ||
| margin-left: auto; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| .navigation { | ||
| list-style: none; | ||
| height: 100%; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Visual/dom order mismatch
🐞 Bug☼ ReliabilityAgent Prompt
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools