chore: secrets-sync/#79 - #80
Merged
Merged
Conversation
itzjb
marked this pull request as ready for review
August 5, 2026 15:36
daehyeong2
approved these changes
Aug 5, 2026
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 내용
PROD_*10종, environmentproduction)로 옮기는 Sync Config 파이프라인을 추가했어요. 이후 시크릿 교체는 "Secret 갱신 → Sync Config 실행"으로 일원화돼요.deploy/render-secrets.sh신규: stdin 본문을 키 화이트리스트·형식 검증(필수 키 누락 시 기존 파일 무손상 중단) → 활성 세션 게이트 → 원자 교체(+.bak백업) → 재시작 → 헬스 실패 시 백업 자동 복원.deploy/receive-deploy.sh: forced command에sync-config [--dry-run] [--no-restart]verb 추가 — 기존deploy <sha> [--force]동작은 그대로예요..github/workflows/sync-config.yml신규:workflow_dispatch전용, 시크릿 본문은 SSH stdin으로만 전달(러너 로그 미출력), Deploy와 같은 concurrency 그룹(deploy-production)으로 직렬화.deploy/README.md: Secret↔env 매핑 표, 값 교체 절차, write-only 주의사항, 설치 절차(sudoers 1줄 추가)를 문서화했어요.확인 방법
deploy경로 회귀 7케이스 +sync-config허용 4케이스 + 거부 4케이스(허용 외 플래그·중복 플래그·여분 인자·명령 주입 시도).로그 출력 변화 (배포 스크립트 리뷰 항목)
SYNC OK (n keys)/SYNC DRY-RUN changed:[키 이름…] added:[…] removed:[…]/SYNC DEFERRED/FAILED: …/MISSING SECRET: <Secret 이름>.머지 후 필요한 작업 (서버·설정)
render-secrets.sh와 갱신된receive-deploy.sh수동 복사 (README §서버 설치 절차 — "PR 머지 → 수동 복사" 관례).render-secrets.sh1줄 추가.production에PROD_*Secrets 10종 등록 →dry_run으로 확인 후 본 실행 전환 검증.Closes #79