Editorial: Fix the described value type of unit conversion results - #145
Open
jessealama wants to merge 1 commit into
Open
Editorial: Fix the described value type of unit conversion results#145jessealama wants to merge 1 commit into
jessealama wants to merge 1 commit into
Conversation
The Introduction and the note on the value getter both stated that unit conversion always stores a decimal digit string for finite values. That stopped being true in #103, which made `.convertTo` produce a Number unless `fractionDigits` or `significantDigits` is supplied, matching the README change in #101. The note on the value getter was also incomplete in a second way: it did not mention that an Amount constructed from a String holds a String value even when no precision options are given.
|
eemeli
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Introduction and the note on the value getter both stated that unit
conversion always stores a decimal digit string for finite values. That
stopped being true in #103, which made
.convertToproduce a Number unlessfractionDigitsorsignificantDigitsis supplied, matching the READMEchange in #101.
The note on the value getter was also incomplete in a second way: it did
not mention that an Amount constructed from a String holds a String
value even when no precision options are given.