Add sequence units to explainer - #141
Open
eemeli wants to merge 1 commit into
Open
Conversation
|
jessealama
approved these changes
Aug 11, 2026
jessealama
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! I agree that trying to specify significant digits when working with sequence units should throw, at least for now. I think it's worth discussing some of your other opinionated bits in new issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds what I understand to be our current consensus on how to support sequence units (see e.g. #118 and proposal-intl-sequence-units), i.e. using an array as the
.valuewhere appropriate.The spec is not (yet) updated by this change, just the explainer.
Going through the details, there are a few cases that I'm not sure we've covered previously, and on some of which this PR is opinionated:
significantDigitswith sequence units — I recommend we throw an error for this, as the general solution here would effectively require dealing with non-decimal bases.fractionDigits— Are all array values stringified? For example, withsignificantDigits, these can't have precision information attached to them.-per-units mentioned in #140, conversion to/from-and-units requires multiple sequential Number operations that can introduce deviations compared to decimal math.Ping @sffc, @gibson042, @ljharb