Normative: Use the correct decimal digit count for non-decimal inputs - #137
Merged
Merged
Conversation
eemeli
requested changes
Jul 12, 2026
| 1. Let _digitCount_ be the count of digits in the decimal representation of _intlMV_.[[Value]]. | ||
| 1. Else, | ||
| 1. Let _digitCount_ be _intlMV_.[[StringDigitCount]]. | ||
| 1. Assert: _digitCount_ ≥ 1. |
Member
There was a problem hiding this comment.
This assertion fails if value is the empty string. I think basing the conditional above on intlMV.[[StringDigitCount]] being 0 might work as intended?
Member
Author
There was a problem hiding this comment.
Yeah, good catch. Fixed.
jessealama
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #135