Support httpoison 3.0#253
Open
AmanTallarium wants to merge 1 commit into
Open
Conversation
AmanTallarium
force-pushed
the
httpoison-allowed-versions
branch
from
d9cdba5 to
448e0d3
Compare
Author
|
Reverted the lockfile changes as the later versions of finch require elixir >1.15 (which tbf is 3yrs old now). We can bump our minimum elixir version if we want our tests to run with more recent versions of these libs (happy to work through this if desired). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding httpoison 3.0 as an allowed version. This is required because this is the first version that depends on hackney v4, which is the first hackney version that resolves quite a few CVEs.
I also bumped Tesla in the lockfile, so that the lock now contains hackney v4 (to test for any behaviour changes), which revealed a small test failure as httpoison timeouts are now returned as
reason: :timeoutinstead of{:closed, :timeout}.Not sure if the lockfile updates are desired, so happy to revert these if wanted.